- updated to the new pikotools api (child spaces were removed)

some plugins need to be fixed yet: ticket, gallery, group, menu - added current user to default models as "user" - renamed in User: super_user -> is_super_user, env -> admin_env, pass_hash_salted -> is_pass_hash_salted - now Users class has a WinixModel as a base class some plugin calls have to be fixed yet - added UserWrapper model with a pointer to User class - removed from ItemContent: methods for accessing 'meta' and 'admin_meta', now ezc can iterate through Space classes - fixed in env winix function: if there is "changeuser" parameter then we should only switch the user (not save anything)
2021-06-27 23:31:50 +02:00
parent 472490c239
commit 1d18b7fa12
59 changed files with 1419 additions and 1607 deletions
--- a/winixd/core/app.cpp
+++ b/winixd/core/app.cpp
@@ -881,6 +881,11 @@ void App::AddDefaultModels()
 		{
 			cur.request->models.Add(L"request", cur.request);

+			if( cur.session && cur.session->puser )
+			{
+				cur.request->models.Add(L"user", *cur.session->puser);
+			}
+
 			if( cur.request->is_item )
 			{
 				cur.request->models.Add(L"item", cur.request->item);
--- a/winixd/core/crypt.cpp
+++ b/winixd/core/crypt.cpp
@@ -270,7 +270,7 @@ bool Crypt::RSA(bool encrypt, const std::wstring & keypath, const std::string &
 bool Crypt::PassHash(const std::wstring & salt, User & user)
 {
 	bool result = true;
-	user.pass_hash_salted = false;
+	user.is_pass_hash_salted = false;

 	if( user.pass_type != WINIX_CRYPT_HASH_NONE )
 	{
@@ -281,7 +281,7 @@ bool Crypt::PassHash(const std::wstring & salt, User & user)
 		if( HashHex(user.pass_type, pass_salted, user.password) )
 		{
 			if( !salt.empty() )
-				user.pass_hash_salted = true;
+				user.is_pass_hash_salted = true;
 		}
 		else
 		{
--- a/winixd/core/groups.cpp
+++ b/winixd/core/groups.cpp
@@ -71,7 +71,7 @@ void Groups::ReadGroups(Db * db)

 	for(Group & group : groups_tmp)
 	{
-		table.PushBack(group);
+		table.PushBack(group, group.name);
 	}
 }

--- a/winixd/core/sessionmanager.cpp
+++ b/winixd/core/sessionmanager.cpp
@@ -241,7 +241,7 @@ void SessionManager::SetSessionPutLogInfo(Session & ses, bool has_index, unsigne
 		main_log << ", index difference: " << (size_t)difference;

 	if( ses.puser )
-		main_log << log2 << ", user: " << ses.puser->name << ", id: " << ses.puser->id;
+		main_log << log2 << ", user: " << ses.puser->login << ", id: " << ses.puser->id;

 	main_log << log2 << logend;
 }
--- a/winixd/core/sessionparser.cpp
+++ b/winixd/core/sessionparser.cpp
@@ -135,7 +135,7 @@ void SessionParser::MakeSession(long id, long user_id, SessionContainer & contai
 		// !! IMPROVE ME we do not save last_time_get

 		users->IncrementLoggedUsers();
-		log << log2 << "SP: read session id: " << id << " for user: " << puser->name << logend;
+		log << log2 << "SP: read session id: " << id << " for user: " << puser->login << logend;
 	}
 	else
 	{
--- a/winixd/core/system.cpp
+++ b/winixd/core/system.cpp
@@ -87,7 +87,8 @@ void System::set_dependency(WinixModelDeprecated * winix_model)

 	dirs.set_dependency(this);
 	mounts.set_dependency(this);
-	users.set_dependency(this);
+	//users.set_dependency(this);
+	users.set_connector(model_connector);
 	groups.set_dependency(this);
 	rebus.set_dependency(this);
 	load_avg.set_dependency(this);
@@ -140,8 +141,9 @@ void System::Init()
 	mounts.CreateMounts();
 	mounts.ReadMounts();

-	users.SetCur(cur);
-	users.SetSessionManager(session_manager);
+//	users.SetCur(cur);
+//	users.SetSessionManager(session_manager);
+	users.set_connector(model_connector);
 	users.ReadUsers(db);

 	groups.ReadGroups(db); // !! chwilowe przekazanie argumentu, db bedzie zmienione
@@ -533,7 +535,7 @@ bool System::CanChangeUser(const Item & item, long new_user_id)
 		// session must be set
 		return false;
 	
-	if( cur->session->puser && cur->session->puser->super_user )
+	if( cur->session->puser && cur->session->puser->is_super_user )
 		// super user is allowed everything
 		return true;
 		
@@ -553,7 +555,7 @@ bool System::CanChangeGroup(const Item & item, long new_group_id)
 		// session must be set
 		return false;

-	if( cur->session->puser && cur->session->puser->super_user )
+	if( cur->session->puser && cur->session->puser->is_super_user )
 		// super user is allowed everything
 		return true;

@@ -587,7 +589,7 @@ bool System::CanChangePrivileges(const Item & item, int new_priv)
 		// session must be set
 		return false;

-	if( cur->session->puser && cur->session->puser->super_user )
+	if( cur->session->puser && cur->session->puser->is_super_user )
 		// super user is allowed everything
 		return true;

@@ -751,7 +753,7 @@ bool System::CanRemoveRenameChild(const Item & dir, long child_item_user_id)

 	if( cur->session->puser )
 	{
-		if( cur->session->puser->super_user )
+		if( cur->session->puser->is_super_user )
 			return true;

 		if( dir.item_content.user_id != -1 && cur->session->puser->id != -1 && child_item_user_id != -1 )
@@ -811,7 +813,7 @@ bool System::IsSuperUser(long user_id)
 	if( !puser )
 		return false;

-return puser->super_user;
+return puser->is_super_user;
 }


--- a/winixd/core/timezone.cpp
+++ b/winixd/core/timezone.cpp
@@ -258,7 +258,7 @@ bool TimeZone::SetTzDst(pt::Space & year)
 	Dst dst;

 	int year_int = 0;
-	std::wstring * year_name = year.find_child_space_name();
+	std::wstring * year_name = year.get_wstr(L"year");

 	if( year_name )
 		year_int = Toi(*year_name);
@@ -297,7 +297,7 @@ bool TimeZone::SetTz(pt::Space & space)
 	bool result = true;
 	name.clear();

-	std::wstring * space_name = space.find_child_space_name();
+	std::wstring * space_name = space.get_wstr(L"name");

 	if( space_name )
 		name = *space_name;
@@ -309,21 +309,16 @@ bool TimeZone::SetTz(pt::Space & space)
 	if( offset < -h24 || offset > h24 )
 		result = false;

-	pt::Space * dst = space.find_child_space(L"dst");
+	pt::Space::TableType * dst = space.get_table(L"dst");

 	if( dst )
 	{
-		pt::Space::TableType * child_table = dst->find_child_space_table();
-
-		if( child_table )
+		for(pt::Space * dst_space : *dst)
 		{
-			for(pt::Space * year : *child_table)
+			if( !SetTzDst(*dst_space) )
 			{
-				if( !SetTzDst(*year) )
-				{
-					result = false;
-					break;
-				}
+				result = false;
+				break;
 			}
 		}
 	}
--- a/winixd/core/timezones.cpp
+++ b/winixd/core/timezones.cpp
@@ -123,11 +123,11 @@ bool TimeZones::Empty() const

 void TimeZones::ParseZones()
 {
-	pt::Space::TableType * child_table = temp_space.find_child_space_table();
+	pt::Space::TableType * timezones_table = temp_space.get_table(L"timezones");

-	if( child_table )
+	if( timezones_table )
 	{
-		for(pt::Space * zone : *child_table)
+		for(pt::Space * zone : *timezones_table)
 		{
 			temp_zone.Clear();

@@ -155,7 +155,7 @@ void TimeZones::ParseZones()
 			else
 			{
 				log << log1 << "System: problem with reading time zone info from time zone: "
-					<< zone->get_child_space_name() << " (skipping) " << logend;
+					<< zone->to_wstr(L"name") << " (skipping) " << logend;
 			}
 		}
 	}
--- a/winixd/core/ugcontainer.h
+++ b/winixd/core/ugcontainer.h
@@ -5,7 +5,7 @@
 */

 /* 
- * Copyright (c) 2008-2014, Tomasz Sowa
+ * Copyright (c) 2008-2021, Tomasz Sowa
 * All rights reserved.
 * 
 * Redistribution and use in source and binary forms, with or without
@@ -65,7 +65,7 @@ public:
 	Iterator End();
 	SizeType Size();
 	bool     Empty();
-	Iterator PushBack(const Type & type); // can return End() if the user already exists
+	Iterator PushBack(const Type & type, const std::wstring & name); // can return End() if the user already exists
 	void     Clear();

 	bool     Is(long id);
@@ -78,17 +78,20 @@ public:



+
+	// main table
+	Table table;
+
+
 private:

 	// don't copy these objects
 	UGContainer(const UGContainer<Type> &);
 	UGContainer<Type> & operator=(const UGContainer<Type> &);

-	void AddIndexes(Iterator iter);
+	void AddIndexes(Iterator iter, const std::wstring & name);
 	void RebuildIndexes();

-	// main table
-	Table table;

 	// table.size() has O(n) complexity
 	size_t table_size;
@@ -163,16 +166,16 @@ bool UGContainer<Type>::Empty()


 template<class Type>
-typename UGContainer<Type>::Iterator UGContainer<Type>::PushBack(const Type & type)
+typename UGContainer<Type>::Iterator UGContainer<Type>::PushBack(const Type & type, const std::wstring & name)
 {
-	if( Is(type.id) || Is(type.name) )
+	if( Is(type.id) || Is(name) )
 		return End();

 	table.push_back(type);
 	table_size += 1;
 	Iterator i = --table.end();
-	log << log3 << "UGCont: added, id: " << type.id << ", name: " << type.name << logend;
-	AddIndexes(i);
+	log << log3 << "UGCont: added, id: " << type.id << ", name: " << name << logend;
+	AddIndexes(i, name);
 		
 return i;
 }
@@ -242,12 +245,12 @@ return i->second;


 template<class Type>
-void UGContainer<Type>::AddIndexes(UGContainer<Type>::Iterator iter)
+void UGContainer<Type>::AddIndexes(UGContainer<Type>::Iterator iter, const std::wstring & name)
 {
 	table_id.insert( std::make_pair(iter->id, iter) );
-	table_name.insert( std::make_pair(iter->name, iter) );
+	table_name.insert( std::make_pair(name, iter) );
 	
-	log << log4 << "UGCont: added indexes to: id: " << iter->id << ", name: " << iter->name << logend;
+	log << log4 << "UGCont: added indexes to: id: " << iter->id << ", name: " << name << logend;
 }


@@ -286,14 +289,15 @@ bool UGContainer<Type>::Remove(long id)
 		{
 			if( n->second == i->second )
 			{
+
+				log << log4 << "UGCont: removed index_name to: id: " << i->second->id << ", name: " << n->first << logend;
 				table_name.erase(n);
-				log << log4 << "UGCont: removed index_id to: id: " << i->second->id << ", name: " << i->second->name << logend;
 				break;
 			}
 		}

-		log << log4 << "UGCont: removed index_name to: id: " << i->second->id << ", name: " << i->second->name << logend;
-		log << log3 << "UGCont: removed: id: " << i->second->id << ", name: " << i->second->name << logend;
+		log << log4 << "UGCont: removed index_id to: id: " << i->second->id << logend;
+		log << log3 << "UGCont: removed: id: " << i->second->id << logend;
 		table.erase(i->second);
 		table_id.erase(i);
 		result = true;
--- a/winixd/core/users.cpp
+++ b/winixd/core/users.cpp
@@ -5,7 +5,7 @@
 */

 /* 
- * Copyright (c) 2008-2018, Tomasz Sowa
+ * Copyright (c) 2008-2021, Tomasz Sowa
 * All rights reserved.
 * 
 * Redistribution and use in source and binary forms, with or without
@@ -35,6 +35,7 @@
 #include <arpa/inet.h>
 #include "users.h"
 #include "sessionmanager.h"
+#include "slog.h"


 namespace Winix
@@ -45,29 +46,38 @@ namespace Winix
 Users::Users()
 {
 	how_many_logged = 0; // !! CHECK ME may it should be moved to Clear() method?
-	table.set_dependency(this);
+//	table.set_dependency(this);
 	Clear();
 }


-void Users::set_dependency(WinixModelDeprecated * winix_model)
+
+void Users::fields()
 {
-	WinixModelDeprecated::set_dependency(winix_model);
-	table.set_dependency(winix_model);
-	last.set_dependency(winix_model);
+	field(L"users", table.table);
 }


-void Users::SetCur(Cur * pcur)
-{
-	cur = pcur;
-}


-void Users::SetSessionManager(SessionManager * sm)
-{
-	session_manager = sm;
-}
+//void Users::set_dependency(WinixModelDeprecated * winix_model)
+//{
+//	WinixModelDeprecated::set_dependency(winix_model);
+//	table.set_dependency(winix_model);
+//	last.set_dependency(winix_model);
+//}
+
+
+//void Users::SetCur(Cur * pcur)
+//{
+//	cur = pcur;
+//}
+
+
+//void Users::SetSessionManager(SessionManager * sm)
+//{
+//	session_manager = sm;
+//}


 void Users::Clear()
@@ -89,7 +99,7 @@ void Users::ReadUsers(Db * db)

 	for(User & user : users_tmp)
 	{
-		table.PushBack(user);
+		table.PushBack(user, user.login);
 	}
 }

@@ -98,7 +108,7 @@ void Users::ReadUsers(Db * db)

 bool Users::AddUser(const User & user)
 {
-	Table::Iterator i = table.PushBack(user);
+	Table::Iterator i = table.PushBack(user, user.login);
 	
 return (i != table.End());
 }
@@ -173,11 +183,11 @@ bool Users::Remove(long user_id)
 	if( puser )
 	{
 		LogoutUser(user_id);
-		plugin->Call(WINIX_PREPARE_TO_REMOVE_USER, puser);
+		//	plugin->Call(WINIX_PREPARE_TO_REMOVE_USER, puser);  FIXME
 		result = table.Remove(user_id);

-		if( result )
-			plugin->Call(WINIX_USER_REMOVED, user_id);
+//		if( result )
+//			plugin->Call(WINIX_USER_REMOVED, user_id); FIXME
 	}

 return result;
@@ -187,15 +197,20 @@ return result;
 // private
 bool Users::LoginUserCheckSession(bool use_ses_log)
 {
-	if( !cur->session )
+	Session * session = get_session();
+	Log * log = get_logger();
+	SLog * slog = get_session_logger();
+
+	if( !session )
 		return false;

-	if( cur->session->id == 0 )
+	if( session->id == 0 )
 	{
-		log << log1 << "Users: I cannot login a user on a temporary session" << logend;
+		if( log )
+			(*log) << log1 << "Users: I cannot login a user on a temporary session" << logend;

-//		if( use_ses_log )
-//			slog << logerror << T(L"service_unavailable") << logend;
+		if( slog && use_ses_log )
+			(*slog) << logerror << T(L"service_unavailable") << logend;

 		return false;
 	}
@@ -208,34 +223,35 @@ return true;
 User * Users::LoginUserCheckStatus(long user_id, bool use_ses_log)
 {
 	User * puser = GetUser(user_id);
+	Log * log = get_logger();
+	SLog * slog = get_session_logger();

 	if( !puser )
 	{
-		log << log1 << "Users: user id: " << user_id << " is not in system.users table" << logend;
+		if( log )
+			(*log) << log1 << "Users: user id: " << user_id << " is not in system.users table" << logend;

-//		if( use_ses_log )
-//			slog << logerror << T(L"service_unavailable") << logend;
+		if( slog && use_ses_log )
+			(*slog) << logerror << T(L"service_unavailable") << logend;

 		return 0;
 	}

 	if( puser->status != WINIX_ACCOUNT_READY )
 	{
-		log << log1 << "Users: user id: " << user_id << " is not ready for logging in (status: "
+		(*log) << log1 << "Users: user id: " << user_id << " is not ready for logging in (status: "
 			<< puser->status << ")" << logend;

-		if( use_ses_log )
+		if( slog && use_ses_log )
 		{
-			/*
 			if( puser->status == WINIX_ACCOUNT_NOT_ACTIVATED )
-				slog << logerror << T(L"account_not_activated") << logend;
+				(*slog) << logerror << T(L"account_not_activated") << logend;
 			else
 			if( puser->status == WINIX_ACCOUNT_SUSPENDED )
-				slog << logerror << T(L"account_suspended") << logend;
+				(*slog) << logerror << T(L"account_suspended") << logend;
 			else
 			if( puser->status == WINIX_ACCOUNT_BLOCKED )
-				slog << logerror << T(L"account_banned") << logend;
-			*/
+				(*slog) << logerror << T(L"account_banned") << logend;
 		}

 		return 0;
@@ -252,34 +268,43 @@ bool Users::LoginUser(long user_id, bool remember_me, bool use_ses_log)
 		return false;

 	User * puser = LoginUserCheckStatus(user_id, use_ses_log);
+	Log * log = get_logger();
+	Session * session = get_session();
+	SessionManager * session_manager = get_session_manager();
+	Request * request = get_request();

-	if( !puser )
+	if( !puser || !session || !session_manager || !request )
 		return false;

-	PluginRes res = plugin->Call(WINIX_PREPARE_USER_TO_LOGIN, puser);
+	PluginRes res;
+	//PluginRes res = plugin->Call(WINIX_PREPARE_USER_TO_LOGIN, puser); FIXME

 	if( res.res_false > 0 )
 	{
-		log << log3 << "Users: login prevented by a plugin" << logend;
+		if( log )
+			(*log) << log3 << "Users: login prevented by a plugin" << logend;
+
 		return false;
 	}

-	if( cur->session->puser )
+	if( session->puser )
 		LogoutCurrentUser();

-	cur->session->puser       = puser;
-	cur->session->spam_score  = 0;
-	cur->session->remember_me = remember_me;
+	session->puser       = puser;
+	session->spam_score  = 0;
+	session->remember_me = remember_me;

 	// change session id before last.UserLogin()
-	if( !cur->session->new_session )
-		session_manager->ChangeSessionId(cur->session->id);
+	if( !session->new_session )
+		session_manager->ChangeSessionId(session->id);

-	last.UserLogin(user_id, cur->session->puser->name, cur->request->ip, cur->session->id);
+	last.UserLogin(user_id, session->puser->login, request->ip, session->id);
 	how_many_logged += 1;

-	log << log2 << "Users: user " << cur->session->puser->name << " (id: " << user_id << ") logged" << logend;
-	plugin->Call(WINIX_USER_LOGGED);
+	if( log )
+		(*log) << log2 << "Users: user " << session->puser->login << " (id: " << user_id << ") logged" << logend;
+
+	//plugin->Call(WINIX_USER_LOGGED); FIXME

 return true;
 }
@@ -289,18 +314,26 @@ size_t Users::LogoutUser(long user_id)
 {
 	size_t how_many = 0;
 	User * puser = GetUser(user_id);
+	Log * log = get_logger();
+	SessionManager * session_manager = get_session_manager();

-	if( puser )
+	if( puser && session_manager )
 	{
-		log << log2 << "Users: logging out user " << puser->name <<  ", id: "
-			<< puser->id << " from all sessions" << logend;
+		if( log )
+		{
+			(*log) << log2 << "Users: logging out user " << puser->login <<  ", id: "
+				   << puser->id << " from all sessions" << logend;
+		}
 		
 		// WINIX_PREPARE_USER_TO_LOGOUT will be sent by MarkAllSessionsToRemove()
 		how_many = session_manager->MarkAllSessionsToRemove(user_id);
 		how_many_logged -= how_many;

 		if( how_many )
-			log << log3 << "Users: " << how_many << " user(s) were logged out" << logend;
+		{
+			if( log )
+				(*log) << log3 << "Users: " << how_many << " user(s) were logged out" << logend;
+		}
 	}

 return how_many;
@@ -310,20 +343,26 @@ return how_many;

 void Users::LogoutCurrentUser()
 {
-	if( !cur->session || !cur->session->puser )
+	Log * log = get_logger();
+	Session * session = get_session();
+
+	if( !session || !session->puser )
 		return;

-	log << log2 << "Users: user " << cur->session->puser->name <<  ", id: "
-		<< cur->session->puser->id << " logged out" << logend;
+	if( log )
+	{
+		(*log) << log2 << "Users: user " << session->puser->login <<  ", id: "
+			   << session->puser->id << " logged out" << logend;
+	}
 	
-	plugin->Call(WINIX_PREPARE_USER_TO_LOGOUT, cur->session->puser);
-	last.UserLogout(cur->session->puser->id, cur->session->id);
+	//plugin->Call(WINIX_PREPARE_USER_TO_LOGOUT, cur->session->puser);	// FIXME
+	last.UserLogout(session->puser->id, session->id);

 	if( how_many_logged > 0 ) // for safety
 		how_many_logged -= 1;
 	
-	cur->session->puser = 0;
-	cur->session->remember_me = false;
+	session->puser = 0;
+	session->remember_me = false;
 }


--- a/winixd/core/users.h
+++ b/winixd/core/users.h
@@ -5,7 +5,7 @@
 */

 /* 
- * Copyright (c) 2008-2018, Tomasz Sowa
+ * Copyright (c) 2008-2021, Tomasz Sowa
 * All rights reserved.
 * 
 * Redistribution and use in source and binary forms, with or without
@@ -41,7 +41,7 @@
 #include "lastcontainer.h"
 #include "cur.h"
 #include "db/db.h"
-#include "winixmodeldeprecated.h"
+#include "models/winixmodel.h"



@@ -53,13 +53,13 @@ namespace Winix
 class SessionManager;


-class Users : public WinixModelDeprecated
+class Users : public WinixModel
 {
 	typedef UGContainer<User> Table;

 public:

-	void set_dependency(WinixModelDeprecated * winix_model);
+	//void set_dependency(WinixModelDeprecated * winix_model);


 	typedef Table::Iterator Iterator;
@@ -69,8 +69,8 @@ public:

 	Users();

-	void SetCur(Cur * pcur);
-	void SetSessionManager(SessionManager * sm);
+//	void SetCur(Cur * pcur);
+//	void SetSessionManager(SessionManager * sm);

 	void Clear();
 	void ReadUsers(Db * db);
@@ -91,12 +91,17 @@ public:
 	void IncrementLoggedUsers();
 	long HowManyLogged();

+protected:
+
+	void fields();
+
+

 private:

 	Table table;
-	Cur * cur;
-	SessionManager * session_manager;
+	//Cur * cur;
+	//SessionManager * session_manager;
 	long how_many_logged;

 	bool LoginUserCheckSession(bool use_ses_log);